The NYC Pass was very good value. We have used the Pass to visit many museums and it was so convenient.
Didn't use all the vouchers, but used the main ones - 9/11 museum, Empire State, Top of the Rock, Statue of Liberty Cruise which we had to queue for over an hour. Most attractions cost between 30 and 32 dollars so as long as youre there early, it would be better value for money paying direct.
I would say overall the CityPASS is worth it as you can save some money and skip the lines for general admission which is nice. I would prefer that there was a regular change up in institutions covered under CityPASS if there is not already as I would have preferred the replacement of certain places with others not currently included e.g. museums, etc....
Overall though I would recommend the CityPASS for first time visitors/tourists of New York City with time and wanting to see the sights.