After extensive research into pretty much all the tourist passes available in NYC, I settled for the CityPass as I had a good idea of what I wanted to visit, and the CityPass offered the lowest price (I did the math for the equivalent with the other passes).
For complaints about still having to queue, please note that this is the security queue that CityPass has no control over. Once you get past security, you can exchange for admission tickets with relative ease. In fact, there was no need to exchange for tickets at the 9/11 memorial and ESB - simply flash the CityPass QR code and you’re in.
For Circle Line cruise and TOTR, you have to exchange in advanced for a timed ticket - and this is made clear at the CityPass website. In particular, for TOTR, CityPass is the only pass that is accepted for booking of your entry time at the TOTR official website.
The only exception to an otherwise rather pleasant experience was AMNH, where I had to queue about 30mins for security and ticket exchange. But hey, I was there over the Jul 4th weekend so I expected crowds.
All in all, I did all 6 attractions over five days and find it totally worth the money. My advice would be to visit the attractions first thing when they open for least crowds - I did that for TOTR, ESB, 9/11 and the Met and got through with no fuss.